-
Notifications
You must be signed in to change notification settings - Fork 484
JAMES-4150 Make Attachment Storage Optional for PostgreSQL Message Store #2885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: postgresql
Are you sure you want to change the base?
Conversation
|
can you review CI pipeline? |
|
Sounds like a random CI issue, I restarted the build |
Arsnael
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me thank you @omerfarukicen ! Can you just be careful with the unnecessary indents in the code though? Adds noise. Thanks :)
|
@omerfarukicen those errors though look related to me: https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-2885/3/testReport/ Can you have a look please? Thanks :) |
|
It looks related to the docker runner apparently I relaunched a build |
|
Same errors, I believe related to the change |
This PR introduces a configurable option to enable or disable attachment storage in the PostgreSQL mailbox implementation.