MAHOUT-652: Add mypy for static type checking and lock file checking #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added mypy static type checking to pre-commit hooks.
Signed-off-by: ryankert01 <ryan980053@gmail.com>
Contributor
Author
|
@guan404ming @rich7420 @400Ping PTAL, I think we can first make to to |
400Ping
approved these changes
Nov 29, 2025
guan404ming
reviewed
Nov 29, 2025
| name: ruff formatting | ||
| files: \.py$ | ||
|
|
||
| # Static type checking |
Member
There was a problem hiding this comment.
Some of comments seems redundant please help remove them, thanks!
Also let's use the newest version https://github.com/pre-commit/mirrors-mypy/releases/tag/v1.19.0
Member
|
We usually prefix the pr title with issue number for main branch related dev, please help update it, thanks! |
ryankert01
changed the title
ryankert01
changed the title
Contributor
|
it's "MAHOUT-XXX: " |
Signed-off-by: ryankert01 <ryan980053@gmail.com>
guan404ming
changed the title
guan404ming
approved these changes
Nov 29, 2025
Member
guan404ming
left a comment
guan404ming
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick update!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added mypy static type checking to pre-commit hooks.
Purpose of PR
Add mypy for static type checking and lock file checking
Related Issues or PRs
Closes #652
Changes Made
Breaking Changes
Checklist