-
Notifications
You must be signed in to change notification settings - Fork 969
[QDP] add batch kernel support #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QDP] add batch kernel support #700
Conversation
|
|
Point needs improved and possible solution
|
400Ping
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
I could help with this if you need. |
|
LGTM ! |
I think this part should be like Iterator way to fit every size of RAM and prevent OOM at same time. |
Thanks for the kind words! I’ve already implemented some related parts, but really appreciate your willingness to help. Once I wrap things up, I’d be happy to have you review them. |
I am not that really familiar with this part, maybe you could help with this, thanks! |
|
Merge, feel free to open pr to refine this one, thanks for all review! |
* [QDP] Add batch encoding support * Refactor batch pre-processing
Purpose of PR
Related Issues or PRs
Changes Made
Breaking Changes
Checklist