use `maven.compiler.release` instead of `.target` by bmarwell · Pull Request #165 · apache/maven-parent

bmarwell · 2024-02-27T21:11:59Z

Change the properties as mentioned by Sylvester, so we have #224 for the actual Java 17 change

bmarwell · 2024-02-27T21:24:16Z

Will redo this on maven-core first.

olamy · 2024-02-28T05:35:21Z

this means all plugins will be 17 required.
so all plugins upgrading to to this parent will not work for users of maven 3.x and jdk 8/11.
sounds an issue to solve as it would mean eventually having branches for plugins in case of major bugs and/or security issues.

slawekjaranowski

We can not bump JDK in parent ... it will have an impact for all plugins ... but plugins should stay at JDK 8

olamy · 2024-02-28T09:33:51Z

We can not bump JDK in parent ... it will have an impact for all plugins ... but plugins should stay at JDK 8

plugins parent can have

    <javaVersion>8</javaVersion>
    <maven.compiler.source>${javaVersion}</maven.compiler.source>
    <maven.compiler.target>${javaVersion}</maven.compiler.target>

but anyway this need more residents as I guess some plugins will now maven4 API directly so there will be branches...

slachiewicz · 2024-04-14T07:59:26Z

can we split this PR to 2 - one to replace parameters to use .target - with the latest m-compiler-p it no longer requires special profile. That is only technical cleanup.
And then dedicated - only to bump java to 17 as in vote?

hboutemy · 2024-04-14T09:49:56Z

and can we avoid MNG issue for a change that is related to Maven parent POM?

bmarwell · 2024-04-14T15:59:48Z

and can we avoid MNG issue for a change that is related to Maven parent POM?

Sure, both works for me. Will update soon.

bmarwell · 2024-12-30T10:14:31Z

can we split this PR to 2 - one to replace parameters to use .target - with the latest m-compiler-p it no longer requires special profile. That is only technical cleanup.

What exactly are you thinking of?

// Edit: got it :)

Bukama

Thanks for updating this dormant PR :)

+1 (nb)

slawekjaranowski · 2024-12-30T16:12:23Z

pom.xml

    <javaVersion>8</javaVersion>
-    <maven.compiler.source>${javaVersion}</maven.compiler.source>
-    <maven.compiler.target>${javaVersion}</maven.compiler.target>
+    <maven.compiler.release>${javaVersion}</maven.compiler.release>


Should we left old properties and allow to m-compiler-p to use proper one?

What java version will be used by m-compiler-p when we have only maven.compiler.release and build on JDK 8?

Since version 3.13.0 of the Compiler Plugin together with the default javac compilerId you don't need conditional parametrisation of release. The release parameter will only be effective for Java 9 or above, otherwise the source and target will be passed to the compiler.

yes, leave original .source and .target properties.

Done for main properties, not sure whether we need them in other places, too

in ale place should be the same

bmarwell · 2024-12-31T08:00:29Z

Do we want/need an issue? Merge now or later?

slawekjaranowski · 2024-12-31T08:25:47Z

I think that we need preserve also source and target - it will be used for jdk8

slawekjaranowski · 2025-01-03T08:10:03Z

maven-extensions/pom.xml

-        <invoker.maven.compiler.source>${maven.compiler.source}</invoker.maven.compiler.source>
-        <invoker.maven.compiler.target>${maven.compiler.target}</invoker.maven.compiler.target>


please also preserver here

slawekjaranowski · 2025-01-03T08:10:18Z

maven-extensions/pom.xml

-                <maven.compiler.source>${invoker.maven.compiler.source}</maven.compiler.source>
-                <maven.compiler.target>${invoker.maven.compiler.target}</maven.compiler.target>


please also preserver here

slawekjaranowski · 2025-01-03T08:10:32Z

maven-plugins/pom.xml

-        <invoker.maven.compiler.source>${maven.compiler.source}</invoker.maven.compiler.source>
-        <invoker.maven.compiler.target>${maven.compiler.target}</invoker.maven.compiler.target>


please also preserver here

slawekjaranowski · 2025-01-03T08:10:41Z

maven-plugins/pom.xml

-                <maven.compiler.source>${invoker.maven.compiler.source}</maven.compiler.source>
-                <maven.compiler.target>${invoker.maven.compiler.target}</maven.compiler.target>


please also preserver here

slawekjaranowski · 2025-01-03T08:11:37Z

pom.xml

    <javaVersion>8</javaVersion>
-    <maven.compiler.source>${javaVersion}</maven.compiler.source>
-    <maven.compiler.target>${javaVersion}</maven.compiler.target>
+    <maven.compiler.release>${javaVersion}</maven.compiler.release>


in ale place should be the same

github-actions · 2025-05-02T03:15:02Z

This pull request is stale because it has been waiting for feedback for 60 days. Remove the stale label or comment on this PR, or it will be automatically closed in 30 days.

desruisseaux · 2025-05-02T07:21:06Z

Should we left old properties and allow to m-compiler-p to use proper one?
I think that we need preserve also source and target - it will be used for jdk8

Actually, if using version 4 of maven-compiler-plugin, the old source and target properties would need to be removed. The reason is because that plugin tries to be more straightforward regarding the mapping of configuration options to javac parameters (e.g. less of Maven's own opinion of what the default values should have been), and javac does not accept source or target to be specified in same time as release.

Bukama · 2025-05-02T07:33:22Z

Should we left old properties and allow to m-compiler-p to use proper one?
I think that we need preserve also source and target - it will be used for jdk8

Actually, if using version 4 of maven-compiler-plugin, the old source and target properties would need to be removed. The reason is because that plugin tries to be more straightforward regarding the mapping of configuration options to javac parameters (e.g. less of Maven's own opinion of what the default values should have been), and javac does not accept source or target to be specified in same time as release.

But it can still apply source or target when compiling against Java 8?

desruisseaux · 2025-05-02T19:24:50Z

But it can still apply source or target when compiling against Java 8?

Yes, but this is not useful since the plugin requires Java 17 for execution anyway. Therefore, user should specify --release 8 instead, except when using forked JVM.

If we keep default values for source and target, then in the current version of compiler plugin 4, the configuration needs to look like that:

<source/>  <!-- Erase the source configuration inherited from the parent pom -->
<target/>
<release>8</release>

Bukama · 2025-05-03T07:02:29Z

I guess I was not clear what I mean. As of kno (3.x) you can specifiy release8 and the compiler plugin turns that into source/target if you are on JDK 8, which does not know release. But with Maven 4 and JDK 17 this is only a thing if you use another JDK via toolchains or something, right?

so I'm okay to remove sourge/target parameters in the 4x plugin

slachiewicz · 2025-05-03T09:34:40Z

Maven-parent is used for other Maven projects that we maintain, where the base is java 8. If we remove it now - we need to adjust around 100 repos. Please think also about backward compatibility for us but also for users (m-compiler-p) as they usually expect that the project should build smoothly with Maven 3 and 4 should be also without issues

slawekjaranowski requested changes Feb 28, 2024

View reviewed changes

bmarwell changed the title ~~[MNG-8061] Maven: Require Java 17~~ Require Java 17 Dec 30, 2024

bmarwell force-pushed the MNG-8061_java17 branch 2 times, most recently from 457ab8e to a82b8eb Compare December 30, 2024 10:03

bmarwell force-pushed the MNG-8061_java17 branch from a82b8eb to 8939751 Compare December 30, 2024 10:17

bmarwell changed the title ~~Require Java 17~~ use maven.compiler.release instead of .target Dec 30, 2024

bmarwell requested a review from slawekjaranowski December 30, 2024 10:18

bmarwell marked this pull request as ready for review December 30, 2024 10:18

bmarwell requested a review from slachiewicz December 30, 2024 10:18

bmarwell mentioned this pull request Dec 30, 2024

require Java 17, compile to 17 #224

Open

Bukama approved these changes Dec 30, 2024

View reviewed changes

slachiewicz approved these changes Dec 30, 2024

View reviewed changes

slachiewicz added this to the MAVEN-44 milestone Dec 30, 2024

slawekjaranowski reviewed Dec 30, 2024

View reviewed changes

use maven.compiler.release instead of .target

7b7f534

bmarwell force-pushed the MNG-8061_java17 branch from 8939751 to 7b7f534 Compare January 2, 2025 18:20

bmarwell requested a review from slawekjaranowski January 2, 2025 18:21

slawekjaranowski requested changes Jan 3, 2025

View reviewed changes

slawekjaranowski added the waiting-for-feedback Waiting for 90 days until issues or pull request will be closed label Feb 16, 2025

slawekjaranowski removed this from the MAVEN-44 milestone Mar 2, 2025

github-actions bot added the Stale label May 2, 2025

github-actions bot removed the waiting-for-feedback Waiting for 90 days until issues or pull request will be closed label May 2, 2025

slawekjaranowski added the waiting-for-feedback Waiting for 90 days until issues or pull request will be closed label Jul 19, 2025

github-actions bot removed the Stale label Jul 20, 2025

bmarwell closed this Aug 24, 2025

		<invoker.maven.compiler.source>${maven.compiler.source}</invoker.maven.compiler.source>
		<invoker.maven.compiler.target>${maven.compiler.target}</invoker.maven.compiler.target>

		<maven.compiler.source>${invoker.maven.compiler.source}</maven.compiler.source>
		<maven.compiler.target>${invoker.maven.compiler.target}</maven.compiler.target>

Conversation

bmarwell commented Feb 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bmarwell commented Feb 27, 2024

Uh oh!

olamy commented Feb 28, 2024

Uh oh!

slawekjaranowski left a comment

Choose a reason for hiding this comment

Uh oh!

olamy commented Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

slachiewicz commented Apr 14, 2024

Uh oh!

hboutemy commented Apr 14, 2024

Uh oh!

bmarwell commented Apr 14, 2024

Uh oh!

bmarwell commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bukama left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bmarwell Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bmarwell commented Dec 31, 2024

Uh oh!

slawekjaranowski commented Dec 31, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 2, 2025

Uh oh!

desruisseaux commented May 2, 2025

Uh oh!

Bukama commented May 2, 2025

Uh oh!

desruisseaux commented May 2, 2025

Uh oh!

Bukama commented May 3, 2025

Uh oh!

slachiewicz commented May 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bmarwell commented Feb 27, 2024 •

edited

Loading

olamy commented Feb 28, 2024 •

edited

Loading

bmarwell commented Dec 30, 2024 •

edited

Loading

bmarwell Jan 2, 2025 •

edited

Loading