Skip to content

Revert "Always render a GitHub ribbon on the right-hand side (#495)"#517

Closed
slawekjaranowski wants to merge 1 commit intoapache:masterfrom
slawekjaranowski:revert-495
Closed

Revert "Always render a GitHub ribbon on the right-hand side (#495)"#517
slawekjaranowski wants to merge 1 commit intoapache:masterfrom
slawekjaranowski:revert-495

Conversation

@slawekjaranowski
Copy link
Member

This reverts commit 183b4a3.

As we need more discussion about it, my proposition is revert now, do release ...

We will have more time for testing and take a decision.

reference:

@kwin
Copy link
Member

kwin commented Nov 17, 2025

For me it is not clear why to revert this. IIUC @hboutemy only had concerns with this for non-plugins. Did I miss something?

@hboutemy
Copy link
Member

hboutemy commented Nov 17, 2025

exactly: one step after the other
testing on plugins is ok, no need to revert

@slawekjaranowski
Copy link
Member Author

exactly: one step after the other testing on plugins is ok, no need to revert

great now is also clear

@slawekjaranowski slawekjaranowski deleted the revert-495 branch November 18, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants