Add additional locations for auto-discovery to scan #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gnodet can you take a look? |
gnodet
reviewed
Nov 13, 2025
| } else { | ||
| installedDirs.add(Paths.get("/usr/jdk")); | ||
| installedDirs.add(Paths.get("/usr/java")); | ||
| installedDirs.add(Paths.get("/usr/local/java")); |
Contributor
There was a problem hiding this comment.
Which tool uses this directory ?
Contributor
Author
There was a problem hiding this comment.
This is based on the proposed alignment with the Gradle toolchain detection I mentioned in #129 – the original proposal for Gradle is documented in gradle/gradle#23620 and boils down to "people put it there during manual installations as common default".
I have no strong opinion on this and I am willing to exclude this particular search folder as it is a "customary" but ultimately a user-defined location.
gnodet
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional locations for auto-discovery to scan
Resolves #129
Since 3f9736c running tests locally (on macOS) fails the build; I have not yet had the chance to debug this fully and understand whether it's a setup problem on my machine.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.