[WIP] Add new goal add-toolchain for adding new toolchains dynamically #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think this is a very ambitious plan (probably too ambitious). |
|
If it's specifically for GitHub actions, please know that since Maven 3.6.2, Maven will replace environment variables in toolchains.xml. This allows you to setup a toolchains.xml using the environment variables that GitHub Actions give you. An example is this workflow. |
|
How about download JDK from https://adoptium.net/ or https://api.foojay.io/swagger-ui automatically? It's will be very useful for local development. Now I built a CLI to manage JDK versions in toolchains.xml https://github.com/linux-china/maven-toolchains-cli |
Contributor
|
I think this is superseded by #14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Work-In-Progress to gather some feedback.
Integration tests will be added.
Currently Maven toolchains must be configured manually or in other ways.
Especially in ad-hoc build environments like GitHub Actions this requires developers to write Shell scripts or other logic in the pipeline to create the toolchain.xml .
By providing this goal developers would be enabled to execute tests with multiple JDKs without having to run the build multiple times (or as a matrix build) in such ad-hoc build environments.