Add 150 more SVG icons (April 2025 batch), and new artboard mappings#77
Merged
eirikbakke merged 1 commit intoapache:masterfrom May 20, 2025
Merged
Add 150 more SVG icons (April 2025 batch), and new artboard mappings#77eirikbakke merged 1 commit intoapache:masterfrom
eirikbakke merged 1 commit intoapache:masterfrom
Conversation
eirikbakke
force-pushed
the
pr-icons-apr25
branch
2 times, most recently
from
e377678 to
5d2b23a
Compare
eirikbakke
added a commit
to eirikbakke/incubator-netbeans
that referenced
this pull request
Apr 15, 2025
Here is yet another batch of SVG icons for NetBeans. These icons were all drawn by myself, on top of NetBeans' existing icons. This is a continuation of the effort to make NetBeans look good on HiDPI/Retina screens. The changes in this PR were all made by running the IconTasks script in the netbeans-tools repo; see the companion PR apache/netbeans-tools#77 there. The changes consist exclusively of copying in SVG files in appropriate locations (sometimes overwriting existing SVG files to make adjustments to them).
eirikbakke
force-pushed
the
pr-icons-apr25
branch
2 times, most recently
from
c5f3c7e to
5d57242
Compare
eirikbakke
added a commit
to eirikbakke/incubator-netbeans
that referenced
this pull request
Apr 15, 2025
Here is yet another batch of SVG icons for NetBeans. These icons were all drawn by myself, by tracing NetBeans' existing icons. This is a continuation of the effort to make NetBeans look good on HiDPI/Retina screens. The changes in this PR were all made by running the IconTasks script in the netbeans-tools repo; see the companion PR apache/netbeans-tools#77 there. The changes consist exclusively of copying in SVG files in appropriate locations (sometimes overwriting existing SVG files to make adjustments to them).
eirikbakke
added a commit
to eirikbakke/incubator-netbeans
that referenced
this pull request
Apr 15, 2025
Here is yet another batch of SVG icons for NetBeans. These icons were all drawn by myself, by tracing NetBeans' existing icons. This is a continuation of the effort to make NetBeans look good on HiDPI/Retina screens. The changes in this PR were all made by running the IconTasks script in the netbeans-tools repo; see the companion PR apache/netbeans-tools#77 there. The changes consist exclusively of copying in SVG files in appropriate locations (sometimes overwriting existing SVG files to make adjustments to them).
Contributor
|
I only had a quick look, but looked sane to me. I get a bad vibe when I see HTML/XML created by string concatenation, but this is for self consumption, so IMHO ok. Thanks for the work on the icons, these indeed give NetBeans a fresher look. |
Contributor
Author
|
@matthiasblaesing Yes, this is much "rougher" code since it's only for use during development. There's still a fair bit of sanity checking done, e.g. to ensure artboard names don't contain special characters that could break things or require escaping. I'll (squash and) merge this PR now that the companion PR apache/netbeans#8424 is merged and shipped. |
Member
|
Nice work. Thanks! |
BradWalker
approved these changes
May 20, 2025
This commit updates the Adobe Illustrator file that holds all of NetBeans' custom-drawn SVG icons, to include ~150 new icons that were integrated into the main NetBeans repo in a separate PR (apache/netbeans#8424). See the latter PR for screenshots of the new icons. Various new mappings of PNG/GIF file paths to artboard names are also included, and new artboards, with original bitmap icons in a separate layer, were created in the Illustrator file for icons that need to be drawn in the future. New artboards were added in batch using a script that was generated by IconTasks.java. Some icons which contained externally source logos have been omitted from the SVG file output, as they probably need a different license header. I will handle these in a separate PR. Also: * Update icon hashes and mappings to match commit 3c852705 in the main NetBeans repo. Some images in the nbi and harness/libs.nbi.ant modules had been removed, causing merge conflicts in the generated changes for that repo. * Removed one stray artboard. * Improve the IconTasks script to avoid overwriting SVG files that render to an identical bitmap as the existing SVG file. This simplifies new icon PRs.
eirikbakke
force-pushed
the
pr-icons-apr25
branch
from
24c236d to
2db7d7c
Compare
Contributor
Author
|
Thanks, merged! |
Yup. I enjoy the new look of NetBeans. Thanks! |
Contributor
Author
|
@JaroslavTulach Thanks! The work of the original icon set creator Leos Tronicek lives on in these icons; I just traced them for the most part. We also switched to a much lighter-weight SVG library in apache/netbeans#7941 |
MartinBalin
pushed a commit
to apache/netbeans-vscode
that referenced
this pull request
Jun 17, 2025
Here is yet another batch of SVG icons for NetBeans. These icons were all drawn by myself, by tracing NetBeans' existing icons. This is a continuation of the effort to make NetBeans look good on HiDPI/Retina screens. The changes in this PR were all made by running the IconTasks script in the netbeans-tools repo; see the companion PR apache/netbeans-tools#77 there. The changes consist exclusively of copying in SVG files in appropriate locations (sometimes overwriting existing SVG files to make adjustments to them).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the Adobe Illustrator file that holds all of NetBeans' custom-drawn SVG icons, to include ~150 new icons that will be integrated into the main NetBeans repo in this separate PR.
Various new mappings of PNG/GIF file paths to artboard names are also included, and new artboards, with original bitmap icons in a separate layer, were created in the Illustrator file for icons that need to be drawn in the future. New artboards were added in batch using an Illustrator script that was generated by IconTasks.java.
The following page, generated by IconTasks.java, shows all current mappings from old bitmap icons to new SVG icons after this PR:
https://people.csail.mit.edu/ebakke/misc/netbeans-icons-250415.html
Contents of the Illustrator file after this PR, in the "New Vector" layer:
Contents of the Illustrator file after this PR, in the "Old Bitmaps" layer (these are old PNG or GIF files that have at least been assigned an artboard name):