CI: build and start testing on JDK 24-ea#7974
Merged
mbien merged 1 commit intoapache:masterfrom Nov 22, 2024
Merged
Conversation
- java hints job remains on 23 and has to wait for nb-javac 24 - bump CV tests from JDK 22 to 23 - minor cleanup
mbien
commented
Nov 19, 2024
| --add-opens=java.desktop/javax.swing.text=ALL-UNNAMED \ | ||
| --add-opens=java.desktop/sun.awt=ALL-UNNAMED \ | ||
| --add-modules=jdk.jdwp.agent,jdk.attach,jdk.jdi,jdk.jshell,java.compiler,jdk.compiler,jdk.management,jdk.unsupported,jdk.internal.le,jdk.internal.ed,jdk.internal.opt,jdk.internal.jvmstat \ | ||
| --add-modules=java.compiler \ |
Member
Author
There was a problem hiding this comment.
This is for CV tests on 23: JDK 23 added jdk.internal.md which we would have to add to the list. This would prevent the JVM from starting on JDKs <22 however.
Adding only java.compiler seems to work, since according to the doc:
--add-modules <module name>[,<module name>...]
root modules to resolve in addition to the initial module.
this seems to add all transitive deps automatically.
matthiasblaesing
approved these changes
Nov 22, 2024
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted from #7928