Improve stability of Java code completion (sealed) tests.#8066
Merged
lahodaj merged 2 commits intoapache:masterfrom Dec 18, 2024
Merged
Improve stability of Java code completion (sealed) tests.#8066lahodaj merged 2 commits intoapache:masterfrom
lahodaj merged 2 commits intoapache:masterfrom
Conversation
b6f9dbf to
ba04482
Compare
Member
|
could you add those two lines from #8025 this gets rid of repeated context dumps which make the log hard to read |
mbien
approved these changes
Dec 17, 2024
Member
mbien
left a comment
There was a problem hiding this comment.
all green - one test less to worry about. Thanks a lot for stabilizing the completion tests!
Contributor
Author
|
Lets see how this works (and if it work well enough). If this turns out to work OK, maybe we need to generalize the approach, and use it in other tests that do Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.