[JS] Prevent NPE for mark occurrences#8071
Merged
junichi11 merged 1 commit intoapache:masterfrom Dec 18, 2024
Merged
Conversation
Member
junichi11
commented
Dec 18, 2024
junichi11
commented
- See the changes in Code cleanup for csl.editor.semantic package #8028
- See the changes in apacheGH-8028
junichi11
added
the
JavaScript
matthiasblaesing
approved these changes
Dec 18, 2024
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Thank you - makes sense to me!
Member
|
hi @junichi11, would you mind updating the PR titles a bit so that it distinguishes the two PRs (#8070) from each other. I think one is about mark occurrences in php the other in JS, right? - looks better in the release notes :) thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.