Ensure left search results panel is always visible.#8088
Ensure left search results panel is always visible.#8088mbien merged 2 commits intoapache:masterfrom
Conversation
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me.
matthiasblaesing
left a comment
There was a problem hiding this comment.
And this was nagging at me: There is also BasicReplaceResultsPanel. This looks as if it should get the same treatment.
Good catch - I'll take a look. Oh boy, I really hate copy pasted code. Will try to deduplicate this a bit if possible. |
initialize divider position with a minimal value.
- BasicReplaceResultsPanel extends BasicSearchResultsPanel - less code duplication
fc77252 to
6635544
Compare
|
@matthiasblaesing added the change to the first commit. The second commit refactors the two panels ( |
matthiasblaesing
left a comment
There was a problem hiding this comment.
We might have to bikeshed the 250px value at some point, but as it is saved, it should be ok. So makes sense to me. Thank you.
initialize divider position with a minimal value. This will always reset the value to at least 250 even if it is changed by the user to less.
fixes #8064
I could reproduce this sometimes with
I believe what happens in this case is that the divider isn't initialized (which is fine by itself) but the computed width of the left panel is 0 for some reason too (which is not ok).