csl.api: Fix GsfSemanticLayer after 0ba2e7a43595d2a267c1fda58b469e6e947f8830#8103
Merged
matthiasblaesing merged 1 commit intoapache:masterfrom Jan 1, 2025
Merged
Conversation
The implementation of GsfSemanticLayer#firstSequenceElement returns wrong/out-of-range values for the first element. This in turn causes tooltip/rendering errors when the sequence is used/positioned. Closes: apache#8102
matthiasblaesing
added
the
ci:dev-build
lkishalmi
approved these changes
Dec 31, 2024
Contributor
lkishalmi
left a comment
lkishalmi
left a comment
There was a problem hiding this comment.
Seems to be good.
If I get this right, the original implementation based on binary search were wrong, as it gave back the "insert" position of the offset, instead of the position of the element before that offset.
Contributor
|
Thank you @matthiasblaesing !, I was completely on wrong track tracing this! |
junichi11
approved these changes
Jan 1, 2025
Member
junichi11
left a comment
junichi11
left a comment
There was a problem hiding this comment.
I've verified the problem is fixed. The unit test is so nice. Thank you!
Contributor
Author
|
@lkishalmi @junichi11 thank you both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of GsfSemanticLayer#firstSequenceElement returns wrong/out-of-range values for the first element. This in turn causes tooltip/rendering errors when the sequence is used/positioned.
Closes: #8102