CSS: Improve parsing of custom @-rules#8104
Merged
matthiasblaesing merged 1 commit intoapache:masterfrom Jan 11, 2025
Merged
Conversation
It was observed, that custom @-rules failed to properly parse when
there was no whitespace present between the rule and the opening brace.
While this parsed:
@-ms-viewport {
width:1024px;
}
This was not:
@-ms-viewport{
width:1024px;
}
matthiasblaesing
added
CSS
Contributor
Author
|
@DarryStraits you raised the issue about failed parsing of the sample depicted in the PR description. A test built is available from the checkpage or directly. Please see if that fixes your issue. |
lkishalmi
approved these changes
Jan 2, 2025
Contributor
lkishalmi
left a comment
lkishalmi
left a comment
There was a problem hiding this comment.
As far as I could see, this seems to be fine.
Contributor
Author
|
@lkishalmi thanks for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was observed, that custom @-rules failed to properly parse when there was no whitespace present between the rule and the opening brace.
While this parsed:
This was not: