DirectoryChooserUI button position adjustments#8105
Merged
mbien merged 1 commit intoapache:masterfrom Jan 2, 2025
Merged
Conversation
Updated spacers to - vertically center toolbar buttons - fix horizontal toolbar button positions - fix vertical approve/cancel button positions and reduce gap
mbien
added
Platform
eirikbakke
approved these changes
Jan 2, 2025
Contributor
eirikbakke
left a comment
eirikbakke
left a comment
There was a problem hiding this comment.
Nice, thanks for adjusting!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noticed some positioning issues while looking at the new svg icons (#8083)
Updated spacers to
updated:
NB 24:
(open both screenshots in separate tabs and switch between them)