Merged
Conversation
eirikbakke
added
Code cleanup
matthiasblaesing
approved these changes
Jan 28, 2025
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
I tend to agree with the removal. We might need to tell people that they can grab the nbm from maven central:
and should be good if their plugins rely in batik.
Member
possibly as temporary workaround, but with integration of this PR the nbm won't be updated again. The only long-term solution for users which relied on that dependency would be to maintain and ship their own lib wrapper. |
As NetBeans has switched to JSVG for SVG loading, and JSVG has been tested for a while, we can now remove the Batik library as previously envisioned. See apache#7969
eirikbakke
force-pushed
the
pr-removebatik
branch
from
16e50c5 to
088a838
Compare
Contributor
Author
|
Rebased on master for merging after tests pass again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7941, we switched NetBeans' SVG icon loading library from Batik to JSVG. As discussed in the latter issue, we can now remove the Batik library altogether, as we have used JSVG for a while and seen no issues.
(This is for the next NB release, not the one freezing today.)
Closes #7969.