Fix ClipboardHandlerTest after changes to QuietEditorPane#8476
Closed
mbien wants to merge 1 commit intoapache:deliveryfrom
Closed
Fix ClipboardHandlerTest after changes to QuietEditorPane#8476mbien wants to merge 1 commit intoapache:deliveryfrom
mbien wants to merge 1 commit intoapache:deliveryfrom
Conversation
- the editor uses NBClipboard now which works asynchronously - ClipboardHandlerTest expects copy/paste to be blocking operations - lets sync after copy/paste operations
mbien
force-pushed
the
wait-for-nbclipboard_delivery
branch
from
f553f9d to
dd539a0
Compare
Contributor
|
looks green :D |
| private static void syncNbClipboard() { | ||
| NbClipboard nbclip = Lookup.getDefault().lookup(NbClipboard.class); | ||
| assertNotNull("active NbClipboard expected", nbclip); | ||
| try { |
Member
There was a problem hiding this comment.
Calling getContents() might be better here? It should roughly match what was happening before.
Member
Author
There was a problem hiding this comment.
blocking on the tasks is the most-direct way to sync on the clipboard. The method is also used from another test.
Member
There was a problem hiding this comment.
So is getContents. I don't think we should change this test, and if we do I think it should use the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NBClipboardsince Restore clipboard history for editor by using ExClipboard instead of directly accessing system clipboard #8462 which works asynchronouslyClipboardHandlerTestexpects copy/paste to be blocking operationslets see if this works