Add support for GlassFish 7.1.0, and GlassFish 8.0.0-M15#9072
Add support for GlassFish 7.1.0, and GlassFish 8.0.0-M15#9072dmainardi wants to merge 3 commits intoapache:masterfrom
Conversation
|
Even if tests pass Netbeans is not able to start Glassfish 7.1.0. I think it is because of Glassfish's breaking changes made for this release, for example see eclipse-ee4j/glassfish#25553 or eclipse-ee4j/glassfish#25183 |
pepness
left a comment
There was a problem hiding this comment.
These new releases from GlassFish (8M14 / 7.1.0) had some breaking changes, when you register the server there is an error and when you try to start the server a different error appear.
Please compile this PR and test it locally to verify that it work on your machine and if it not work like in mine compare the errors.
enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/ServerDetails.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Better reverse this to GlassFish version 7.0.25 and create a new test testGetInstanceforVersionGF71(), as this is a medium update going from 7.0.X to 7.Y.X.
ac4a044 to
6bd4b52
Compare
|
I updated the code as per your suggestion. |
Update NOTICE to 2026
|
Shouldn't we consider this one on NB29? Without this one there is no GF server that can run on Java 25. |
|
yeah that would make sense. I can squash/rebase/retarget this PR to delivery if its ok with @dmainardi. |
|
For me it is ok. I was just waiting for @pepness approval since this is the first time I contributed to Netbeans code and I do not want to push some "bad code". |
Added --module-path and --add-modules in order to start Glassfish after the bootstrap was redesigned.
6bd4b52 to
2771132
Compare
|
done. branch squashed, rebased and PR targets delivery now. CI will create a dev build for testing. for the record: we usually only allow fixes during RC phase, but this is mostly about configuration files with low risk for side effects so I believe we can do an exception here. But if other PMC members would be against it i would understand that too - i can rebase it again ;) would still need a review pass and testing |
|
still need work and cut for next RC is tomorrow. so back to NB30 |
|
I read that GF 8 is now released. |
Thanks @pepness
NetBeans GlassFish module notes:
Release Notes for GlassFish 7
Release Notes for GlassFish 8