Use Runtime.version() where applicable and remove unreachable code#9213
Open
mbien wants to merge 1 commit intoapache:masterfrom
Open
Use Runtime.version() where applicable and remove unreachable code#9213mbien wants to merge 1 commit intoapache:masterfrom
mbien wants to merge 1 commit intoapache:masterfrom
Conversation
- replace reflective access with direct calls - replace java version parsing with Runtime.version() - remove dead code paths due to past JDK bumps - minor cleanup in touched files
mbien
added
Code cleanup
Member
Author
|
@haidubogdan this also removes some php code which shouldn't be reachable anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime.version()got inspired by the discussion in #9181 and a few things in my stash