Fixed: Force Complete Purchase Order logic to support items split into multiple ship groups (OFBIZ-13327) #934
+86
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix bugs that occur when order items are split into more than one ship group. No functional changes.
No functional changes. This change prepares for the upcoming refactoring needed to properly support cancellation for items split across multiple ship groups.
… of a specfic ship group
… items split into multiple ship groups
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is needed because the cancelOrderItem service, that is used in the 'Force Complete Purchase Order' workflow, doesn't work correctly in case of item's units split into multiple ship groups.
The issue can be reproduced as described in the attached document.
PR_force_complete_order_how_to_reproduce_the_issue.pdf