Skip to content

ci: switches memcached image to bitnamisecure image #6583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kingsword09 wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

ci: switches memcached image to bitnamisecure image #6583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f4ae209
ci: switches memcached image to bitnamisecure image
kingsword09 Sep 22, 2025
1ab3807
chore: add logs
kingsword09 Sep 22, 2025
55638fd
chore: modify image
kingsword09 Sep 22, 2025
1912928
ci: test
kingsword09 Sep 22, 2025
8941c5d
chore: add env
kingsword09 Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/services/memcached/memcached_with_auth/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,25 @@ runs:
shell: bash
working-directory: fixtures/memcached
run: docker compose -f docker-compose-memcached-with-auth.yml up -d --wait

- name: Print memcached logs on failure
if: failure()
shell: bash
working-directory: fixtures/memcached
run: |
echo "==== docker ps -a ===="
docker ps -a
echo "==== docker logs memcached-memcached-1 ===="
docker logs memcached-memcached-1 || true
echo "==== docker compose logs ===="
docker compose -f docker-compose-memcached-with-auth.yml logs || true

Comment on lines +29 to +40
Copy link
Member

@Xuanwo Xuanwo Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to to remove this?

Copy link
Contributor Author

@kingsword09 kingsword09 Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There still seems to be a problem with the bitnamisecure/memcached image, but I haven't figured out exactly what's going on, the authentication doesn't seem to be reporting errors anymore, but the tests are timing out a ton!

- name: Setup
shell: bash
run: |
cat << EOF >> $GITHUB_ENV
OPENDAL_MEMCACHED_ENDPOINT=tcp://127.0.0.1:11211
OPENDAL_MEMCACHED_ROOT=/
OPENDAL_MEMCACHED_USERNAME=test
OPENDAL_MEMCACHED_PASSWORD=test
OPENDAL_MEMCACHED_USERNAME=root
OPENDAL_MEMCACHED_PASSWORD=opendal
EOF
11 changes: 8 additions & 3 deletions fixtures/memcached/docker-compose-memcached-with-auth.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,19 @@

services:
memcached:
image: docker.io/bitnamilegacy/memcached:1.6.39-debian-12-r0
image: docker.io/bitnamisecure/memcached:latest
environment:
# memcache's max item size is 1MiB, But opendal's behavior tests
# will produce larger file.
#
# Specify the setting here to make our test happy.
MEMCACHED_MAX_ITEM_SIZE: 16777216
MEMCACHED_USERNAME: "test"
MEMCACHED_PASSWORD: "test"
MEMCACHED_USERNAME: "root"
MEMCACHED_PASSWORD: "opendal"
MEMCACHED_THREADS: 4
MEMCACHED_MAX_CONNECTIONS: 2048
MEMCACHED_CACHE_SIZE: 128
MEMCACHED_EXTRA_FLAGS: "-B binary"

ports:
- "11211:11211"
Loading