Skip to content

Conversation

@yihong0618
Copy link
Contributor

Which issue does this PR close?

Closes #6860

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

also update pyi with just

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels Dec 4, 2025
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618
Copy link
Contributor Author

since its not a opendal issue its from uv and update uv python no issue here, so this patch will only update the python desc

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618 yihong0618 changed the title fix: make just find uv right chore: update pyi files Dec 8, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should find a way to make sure those pyi files are updated after the core changes. Would you like to add a CI for Python, similar to what we have for Node.js, that checks the diff after generation?

- name: Check diff
run: git diff --exit-code

@yihong0618
Copy link
Contributor Author

We should find a way to make sure those pyi files are updated after the core changes. Would you like to add a CI for Python, similar to what we have for Node.js, that checks the diff after generation?

- name: Check diff
run: git diff --exit-code

of course will add it in this patch

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 18, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 18, 2025
@yihong0618
Copy link
Contributor Author

close as play pyo3-stub-gen on ci and local are all different will bring it back when I have time or others can take it.

@yihong0618 yihong0618 closed this Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: python just install-dev is not right for uv

2 participants