Skip to content

HDDS-14211. Extract base RDBBatchOperation, rename implementation to AtomicRDBBatchOperation #9526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
swamirishi wants to merge 5 commits into
base: master
Choose a base branch
from
+790 −705
Draft

HDDS-14211. Extract base RDBBatchOperation, rename implementation to AtomicRDBBatchOperation #9526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9b08e1f
HDDS-14211. Rename RDBBatchOperation as AtomicRDBBatchOperation and i…
swamirishi Dec 18, 2025
40f7952
Merge remote-tracking branch 'origin/master' into HDDS-14211
adoroszlai Dec 22, 2025
dc51610
fix checkstyle
adoroszlai Dec 22, 2025
08d572e
fix pmd
adoroszlai Dec 22, 2025
f6f1411
fix findbugs
adoroszlai Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ainer-service/src/main/java/org/apache/hadoop/ozone/container/metadata/DatanodeTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,13 @@ public void deleteRange(KEY beginKey, KEY endKey) throws RocksDatabaseException,
}

@Override
public void deleteWithBatch(BatchOperation batch, KEY key) throws CodecException {
public void deleteWithBatch(BatchOperation batch, KEY key) throws CodecException, RocksDatabaseException {
table.deleteWithBatch(batch, key);
}

@Override
public void deleteRangeWithBatch(BatchOperation batch, KEY beginKey, KEY endKey) throws CodecException {
public void deleteRangeWithBatch(BatchOperation batch, KEY beginKey, KEY endKey)
throws CodecException, RocksDatabaseException {
table.deleteRangeWithBatch(batch, beginKey, endKey);
}

Expand Down
2 changes: 1 addition & 1 deletion ...src/main/java/org/apache/hadoop/ozone/container/metadata/SchemaOneDeletedBlocksTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public void delete(String key) throws RocksDatabaseException, CodecException {
}

@Override
public void deleteWithBatch(BatchOperation batch, String key) throws CodecException {
public void deleteWithBatch(BatchOperation batch, String key) throws CodecException, RocksDatabaseException {
super.deleteWithBatch(batch, prefix(key));
}

Expand Down
5 changes: 2 additions & 3 deletions ...hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/metadata/DBTransactionBuffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,19 @@

package org.apache.hadoop.hdds.scm.metadata;

import java.io.Closeable;
import org.apache.hadoop.hdds.utils.db.CodecException;
import org.apache.hadoop.hdds.utils.db.RocksDatabaseException;
import org.apache.hadoop.hdds.utils.db.Table;

/**
* DB transaction that abstracts the updates to the underlying datastore.
*/
public interface DBTransactionBuffer {
public interface DBTransactionBuffer extends Closeable {

<KEY, VALUE> void addToBuffer(Table<KEY, VALUE> table, KEY key, VALUE value)
throws RocksDatabaseException, CodecException;

<KEY, VALUE> void removeFromBuffer(Table<KEY, VALUE> table, KEY key)
throws RocksDatabaseException, CodecException;

void close() throws RocksDatabaseException;
}
Loading