HDDS-14235. Cleanup RDBBatchOperation. #9551
Closed
+145
−167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Author
|
@swamirishi , since there are so many followups for HDDS-13415, how about about reverting it and redoing it? I am fine if you want to make the changes, I can do the reviews. If we choose not redoing HDDS-13415, please review this PR first. |
Contributor
Author
|
Since HDDS-13415 was reverted by HDDS-14240, this PR is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After HDDS-13415, we have
The RDBBatchOperation.Op enum is no longer needed. Also, we should use generic type for supporting both CodecBuffer and byte[] (but not duplicating the code).
What is the link to the Apache JIRA
HDDS-14235
How was this patch tested?
By existing tests.