Skip to content

improve parsing speed for PDFMergerUtility.acroFormLegacyMode method #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valerybokov wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

improve parsing speed for PDFMergerUtility.acroFormLegacyMode method #374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pdfbox/src/main/java/org/apache/pdfbox/multipdf/PDFMergerUtility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.regex.Pattern;

import org.apache.logging.log4j.Logger;
import org.apache.logging.log4j.LogManager;
Expand Down Expand Up @@ -92,6 +93,8 @@ public class PDFMergerUtility
*/
private static final Logger LOG = LogManager.getLogger(PDFMergerUtility.class);

private static final Pattern pattern = Pattern.compile("\\d+");

private final List<Object> sources;
private String destinationFileName;
private OutputStream destinationStream;
Expand Down Expand Up @@ -1302,7 +1305,7 @@ private void acroFormLegacyMode(PDFCloneUtility cloner, PDAcroForm destAcroForm,
if (fieldName != null && fieldName.startsWith(prefix))
{
String suffix = fieldName.substring(prefixLength);
if (suffix.matches("\\d+"))
if (pattern.matcher(suffix).find())
{
nextFieldNum = Math.max(nextFieldNum, Integer.parseInt(suffix) + 1);
}
Expand Down