Skip to content

PHOENIX-7743 : Fix TNFE in IndexTool server side builds for case sensitive names #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
palashc wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −4
Open

PHOENIX-7743 : Fix TNFE in IndexTool server side builds for case sensitive names #2331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a09e27d
PHOENIX-7743 : Fix TNFE in IndexTool server side builds for case sens…
Dec 13, 2025
4f5d54e
remove comment
Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions ...server/src/main/java/org/apache/phoenix/mapreduce/PhoenixServerBuildIndexInputFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
import org.apache.phoenix.util.EnvironmentEdgeManager;
import org.apache.phoenix.util.PhoenixRuntime;
import org.apache.phoenix.util.ScanUtil;
import org.apache.phoenix.util.SchemaUtil;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down Expand Up @@ -92,8 +93,9 @@ private class TransformingDataTableQueryPlanBuilder implements QueryPlanBuilder
public QueryPlan getQueryPlan(PhoenixConnection phoenixConnection, String oldTableFullName,
String newTableFullName) throws SQLException {
PTable newTable = phoenixConnection.getTableNoCache(newTableFullName);
String quotedOldTableName = getQuotedTableNameForSQL(oldTableFullName);
ServerBuildTransformingTableCompiler compiler =
new ServerBuildTransformingTableCompiler(phoenixConnection, oldTableFullName);
new ServerBuildTransformingTableCompiler(phoenixConnection, quotedOldTableName);
MutationPlan plan = compiler.compile(newTable);
return plan.getQueryPlan();
}
Expand All @@ -104,8 +106,9 @@ private class DataTableQueryPlanBuilder implements QueryPlanBuilder {
public QueryPlan getQueryPlan(PhoenixConnection phoenixConnection, String dataTableFullName,
String indexTableFullName) throws SQLException {
PTable indexTable = phoenixConnection.getTableNoCache(indexTableFullName);
String quotedDataTableName = getQuotedTableNameForSQL(dataTableFullName);
ServerBuildIndexCompiler compiler =
new ServerBuildIndexCompiler(phoenixConnection, dataTableFullName);
new ServerBuildIndexCompiler(phoenixConnection, quotedDataTableName);
MutationPlan plan = compiler.compile(indexTable);
return plan.getQueryPlan();
}
Expand All @@ -117,7 +120,8 @@ public QueryPlan getQueryPlan(PhoenixConnection phoenixConnection, String dataTa
String indexTableFullName) throws SQLException {
QueryPlan plan;
try (final PhoenixStatement statement = new PhoenixStatement(phoenixConnection)) {
String query = "SELECT count(*) FROM " + indexTableFullName;
String quotedIndexName = getQuotedTableNameForSQL(indexTableFullName);
String query = "SELECT count(*) FROM " + quotedIndexName;
plan = statement.compileQuery(query);
TableRef tableRef = plan.getTableRef();
Scan scan = plan.getContext().getScan();
Expand All @@ -139,6 +143,12 @@ public QueryPlan getQueryPlan(PhoenixConnection phoenixConnection, String dataTa

private QueryPlanBuilder queryPlanBuilder;

private String getQuotedTableNameForSQL(String normalizedFullTableName) {
String schemaName = SchemaUtil.getSchemaNameFromFullName(normalizedFullTableName);
String tableName = SchemaUtil.getTableNameFromFullName(normalizedFullTableName);
return SchemaUtil.getFullTableNameWithQuotes(schemaName, tableName);
}

@Override
protected QueryPlan getQueryPlan(final JobContext context, final Configuration configuration)
throws IOException {
Expand Down
2 changes: 1 addition & 1 deletion phoenix-core-server/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ private Job configureJobForServerBuildIndex() throws Exception {
configuration.setBooleanIfUnset(
PhoenixConfigurationUtil.MAPREDUCE_RANDOMIZE_MAPPER_EXECUTION_ORDER, true);

PhoenixConfigurationUtil.setIndexToolDataTableName(configuration, dataTableWithSchema);
PhoenixConfigurationUtil.setIndexToolDataTableName(configuration, qDataTable);
PhoenixConfigurationUtil.setIndexToolIndexTableName(configuration, qIndexTable);
PhoenixConfigurationUtil.setIndexToolSourceTable(configuration, sourceTable);
if (startTime != null) {
Expand Down