-
Notifications
You must be signed in to change notification settings - Fork 28
feat: introduce workspaces #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: introduce workspaces #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice improvement, @binarycat0 ! I think this feature is worth adding to Polaris UI.
I cannot say much about actual code change, but I ran this UI in my local and it worked very well. Some UX notes below.
- In the "create workspace" there are auto-filled values, but I do not see an easy way to accept them... the
Createbutton does not work unless I type in the same values manually. - When under Home it's not clear what workspace I'm in. Current Realm is shown, though, but it's not 1:1 with workspace.
Workspacesshow all possible workspaces, but on the left-hand pane this page is parallel toCatalogs, whileCatalogsis specific to the current workspace, I assume, right? This is kind of awkward. I'd proposed to remove theWorkspacespage from the left-hand pane and only show the current workspace when the user is logged in.
Hello! Thanks for the interesting findings and your experience, it's very valuable. Yeah, I'm agree about workspaces, it's really not obvious which is active and how to switch between them and if it's available even. I have a couple ideas how to manage this, I will give it a try. |
|
During my work on this PR I introduce "prettier" linting tool and then later I decided to move linting-changes as separate PR. |
Motivation
The previous configuration approach required environment variables for each Polaris instance, which doesn't align with the concept of a management console that can connect to multiple Polaris environments. This created inflexibility when experimenting with different Polaris deployments and authentication methods.
This work is a preparation before introduce OIDC integration with Console UI: [WIP] #125
Features
Benefits
Additional Details
Minors
make formatutil commandcc: @jbonofre @sohanhonavar @adam-christian-software @dimas-b
Modified login form
Ability to chose between the multiple workspaces and auth methods
Dummy warning about WIP on the OIDC implementation
Workspaces Management space
Show active worskpace. Switching between workspaces