MCP: Add unit tests for all tools and refactors #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyrain
requested review from
HonahX,
MonkeyCanCode,
RussellSpitzer,
adutra,
ajantha-bhat,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
jackye1995,
jbonofre,
pingtimeout,
singhpk234,
snazy,
takidau and
vvcephei
as code owners
jbonofre
approved these changes
Nov 17, 2025
| @@ -0,0 +1,54 @@ | |||
| """Unit tests for ``polaris_mcp.tools.catalog_role``.""" | |||
Contributor
There was a problem hiding this comment.
Missing the license header here.
Do we have a Git issue for auto-checking the license?
| @@ -0,0 +1,57 @@ | |||
| """Unit tests for ``polaris_mcp.tools.catalog``.""" | |||
Contributor
There was a problem hiding this comment.
Missing header
| @@ -0,0 +1,40 @@ | |||
| """Unit tests for ``polaris_mcp.tools.policy``.""" | |||
Contributor
There was a problem hiding this comment.
Missing header
| @@ -0,0 +1,43 @@ | |||
| """Unit tests for ``polaris_mcp.tools.principal_role``.""" | |||
Contributor
There was a problem hiding this comment.
Missing header
| @@ -0,0 +1,45 @@ | |||
| """Unit tests for ``polaris_mcp.tools.principal``.""" | |||
Contributor
There was a problem hiding this comment.
Missing header
Contributor
adam-christian-software
left a comment
adam-christian-software
left a comment
There was a problem hiding this comment.
Overall, I like the changes. I especially like that we are injecting in the RestTool rather than building that dependency.
Personally, I would add a Description to the PR since that helps keep our project clean.
MonkeyCanCode
approved these changes
Nov 23, 2025
Contributor
Author
|
Thanks all for the review! |
MonkeyCanCode
pushed a commit
to MonkeyCanCode/polaris-tools
that referenced
this pull request
Nov 23, 2025
MonkeyCanCode
pushed a commit
to MonkeyCanCode/polaris-tools
that referenced
this pull request
Nov 23, 2025
MonkeyCanCode
pushed a commit
to MonkeyCanCode/polaris-tools
that referenced
this pull request
Nov 25, 2025
MonkeyCanCode
added a commit
that referenced
this pull request
Nov 25, 2025
* Added support for configurable HTTP timeout * MCP: Add unit tests for all tools and refactors (#51) * Added support for configurable HTTP timeout * Fix lint --------- Co-authored-by: Yufei Gu <yufei@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @adam-christian-software @HonahX