Skip to content

Guides: compose dependencies / long-option#3611

Merged
snazy merged 1 commit intoapache:mainfrom
snazy:guides-depends-longopt
Jan 31, 2026
Merged

Guides: compose dependencies / long-option#3611
snazy merged 1 commit intoapache:mainfrom
snazy:guides-depends-longopt

Conversation

@snazy
Copy link
Member

@snazy snazy commented Jan 29, 2026

Docker compose's "short" depends_on syntax (just mentioning the dependent service) does not assert on the expected condition (service_healthy or service_completed_successfully). This can lead to services being started too early, although their dependencies are not in the expected state.

This change updates the affected parts to use the "long" syntax.

Docker compose's "short" `depends_on` syntax (just mentioning the dependent service) does not assert on the expected condition (`service_healthy` or `service_completed_successfully`). This can lead to services being started too early, although their dependencies are not in the expected state.

This change updates the affected parts to use the "long" syntax.
@snazy snazy force-pushed the guides-depends-longopt branch from e49fa5a to 79b13e1 Compare January 29, 2026 14:16
@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Jan 29, 2026
polaris:
condition: service_healthy
polaris-setup:
condition: service_completed_successfully
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are changing to tail forever on the other PR, we will need to change this to service_healthy instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!
I'll adjust the other PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it's not strictly needed in the other PR for the telemetry guide, but I've added it for consistency across the guides.

@snazy snazy merged commit 60bfea8 into apache:main Jan 31, 2026
15 checks passed
@snazy snazy deleted the guides-depends-longopt branch January 31, 2026 09:45
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Jan 31, 2026
sungwy pushed a commit to sungwy/polaris that referenced this pull request Feb 7, 2026
Docker compose's "short" `depends_on` syntax (just mentioning the dependent service) does not assert on the expected condition (`service_healthy` or `service_completed_successfully`). This can lead to services being started too early, although their dependencies are not in the expected state.

This change updates the affected parts to use the "long" syntax.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants