Add support for rustfs test-containers#3679
Add support for rustfs test-containers#3679MonkeyCanCode wants to merge 1 commit intoapache:mainfrom
Conversation
dimas-b
left a comment
dimas-b
left a comment
There was a problem hiding this comment.
LGTM with a minor comment. Thanks, @MonkeyCanCode !
| * Rustfs}. | ||
| */ | ||
| // CODE_COPIED_TO_POLARIS from Project Nessie 0.104.2 | ||
| public interface RustfsAccess { |
There was a problem hiding this comment.
I wonder if we could rename MinioAccess to S3Access and reuse it for RustFS... and potentially for other non-AWS backends later... WDYT?
I'm fine with a copy too.
There was a problem hiding this comment.
Using S3Access sounds great but I am not sure if they are truly re-usable (e.g. switch from minio to rustfs would required couple changes already such as environments variables used by them as well as the domain with port when using virtual host style access).
My only concern is, with generic naming, will that be more confusing as we can't really promised switching to another s3 compatible will work (e.g. rustfs to seaweedfs)? I am assuming we would drop minio one day and maybe do the change around that time instead?
There was a problem hiding this comment.
Good points! I'm ok to merge "as is" 🙂
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
2 participants
This is follow up PR for #3663. As concluded in the reference PR, we would want to have both minio test-containers and rustfs test-containers co-existed and migrated NoSQL and Federation tests to RustFS.
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)