PolarisAuthzTestBase: fix insufficient privilege set tests#3691
Open
adutra wants to merge 1 commit intoapache:mainfrom
Open
PolarisAuthzTestBase: fix insufficient privilege set tests#3691adutra wants to merge 1 commit intoapache:mainfrom
adutra wants to merge 1 commit intoapache:mainfrom
Conversation
The method `doTestInsufficientPrivilegeSets()` was incorrectly testing that each privilege in the set was *individually* insufficient. But this is not the intent of a privilege set negative test: the test is expected to fail even if *all* privileges in the set are granted. See for instance `PolicyCatalogHandlerAuthzTest.testDetachPolicyFromNamespaceInsufficientPrivilege()`: the intent is to verify that it is insufficient to have *both* `POLICY_DETACH` and `CATALOG_DETACH_POLICY`.
Contributor
Author
|
Pinging @collado-mike and @HonahX – let me know if my analyzis is correct! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
doTestInsufficientPrivilegeSets()was incorrectly testing that each privilege in the set was individually insufficient.But this is not the intent of a privilege set negative test: the test is expected to fail even if all privileges in the set are granted.
See for instance
PolicyCatalogHandlerAuthzTest.testDetachPolicyFromNamespaceInsufficientPrivilege(): the intent is to verify that it is insufficient to have bothPOLICY_DETACHandCATALOG_DETACH_POLICY.Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)