Skip to content

Comments

[fix] [io] Fix check style in JdbcUtils#18124

Closed
hangc0276 wants to merge 1 commit intoapache:masterfrom
hangc0276:chenhang/fix_check_style_failed
Closed

[fix] [io] Fix check style in JdbcUtils#18124
hangc0276 wants to merge 1 commit intoapache:masterfrom
hangc0276:chenhang/fix_check_style_failed

Conversation

@hangc0276
Copy link
Contributor

@hangc0276 hangc0276 commented Oct 20, 2022

Motivation

When running mvn install -DskipTests command, it will fail with the following exception.

[INFO] --- maven-checkstyle-plugin:3.1.2:check (checkstyle) @ pulsar-io-jdbc-core ---
[INFO] There are 2 errors reported by Checkstyle 8.37 with /Users/hangc/Workspace/sourcecode/PR/pulsar/buildtools/src/main/resources/pulsar/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/pulsar/io/jdbc/JdbcUtils.java:[124,60] (whitespace) WhitespaceAround: ':' is not preceded with whitespace.
[ERROR] src/main/java/org/apache/pulsar/io/jdbc/JdbcUtils.java:[125,66] (whitespace) WhitespaceAround: ':' is not preceded with whitespace.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  4.691 s
[INFO] Finished at: 2022-10-20T08:50:42+08:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (checkstyle) on project pulsar-io-jdbc-core: You have 2 Checkstyle violations. -> [Help 1]

Modification

Fix the check style.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

hangc0276#5

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 20, 2022
@hangc0276 hangc0276 changed the title [fix][io]fix check style in JdbcUtils [fix] [io] Fix check style in JdbcUtils Oct 20, 2022
@hangc0276 hangc0276 self-assigned this Oct 20, 2022
@hangc0276 hangc0276 added the type/bug The PR fixed a bug or issue reported a bug label Oct 20, 2022
@hangc0276 hangc0276 added this to the 2.11.0 milestone Oct 20, 2022
@Technoboy-
Copy link
Contributor

Closed by #18122

@Technoboy- Technoboy- closed this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants