[fix][client] Fix authentication not update after changing the serviceUrl#19510
Merged
nodece merged 1 commit intoapache:masterfrom Feb 14, 2023
Conversation
codelipenghui
approved these changes
Feb 14, 2023
Contributor
|
/pulsarbot run-failure-checks |
BewareMyPower
approved these changes
Feb 14, 2023
coderzc
approved these changes
Feb 14, 2023
Contributor
|
Hi @hangc0276, did you have any plans to update the docs for this fix? Just want to make sure it can catch up with the release schedule. |
Contributor
Author
@momo-jun sorry, I add the wrong doc tag. This Pr doesn't need any doc updates. |
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2023
…eUrl (apache#19510) (cherry picked from commit 0f025f3) (cherry picked from commit 132abe9)
Technoboy-
pushed a commit
that referenced
this pull request
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When we use cluster level failover and enabled authentication, we found the authentication couldn't update in the HttpLookupService. The root cause is that the HttpLookupService cached the httpClient, but the
updateServiceUrlonly updates the target serviceUrl for the httpClient, without any updates for authentication.pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/HttpLookupService.java
Lines 65 to 75 in 70c4003
Modifications
Call
pulsarClient.reloadLookUp()to update the authentication manually when the target cluster is switched.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: hangc0276#10