[improve] [broker] Add logs for the checksum comparation#21676
Closed
poorbarcode wants to merge 5 commits intoapache:masterfrom
Closed
[improve] [broker] Add logs for the checksum comparation#21676poorbarcode wants to merge 5 commits intoapache:masterfrom
poorbarcode wants to merge 5 commits intoapache:masterfrom
Conversation
poorbarcode
requested review from
Technoboy-,
codelipenghui,
coderzc and
gaoran10
poorbarcode
added
release/3.0.3
ready-to-test
and removed
doc-not-needed
Contributor
Author
|
/pulsarbot rerun-failure-checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Many users hit the issue
Failed to verify checksum, see #21557apache/bookkeeper#4140 tries to fix the bug of
Java9IntHash, but @TinyQAQ said the fix did not fix the issue they hit.I want to add some logs to make it can be easier to analyze.
Modifications
VerboseLoggerThrottleis used to avoid too many verbose logs to print. ZK's utility class(RateLogger) does not match our requirements, so we created this one.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x