Skip to content

Comments

[improve] replace jcip annotations to jsr305 annotations#25252

Open
sindhushreem25 wants to merge 8 commits intoapache:masterfrom
sindhushreem25:removeJcip
Open

[improve] replace jcip annotations to jsr305 annotations#25252
sindhushreem25 wants to merge 8 commits intoapache:masterfrom
sindhushreem25:removeJcip

Conversation

@sindhushreem25
Copy link

@sindhushreem25 sindhushreem25 commented Feb 19, 2026

Removal of jcip and moving to spotbugs and javax annotations.

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

…and spotbugs annotations

Removal of jcip and moving to spotbugs and javax annotations .
@github-actions
Copy link

@sindhushreem25 Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Feb 19, 2026
Added the relocation for spotbugs-annotations
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked once more and noticed that spotbugs-annotations doesn't contain the annotations. This is what spotbugs-annotations depends on:

    <dependency>
      <groupId>com.google.code.findbugs</groupId>
      <artifactId>jsr305</artifactId>
      <version>3.0.2</version>
      <scope>compile</scope>
    </dependency>

Please switch to use this dependency directly.

Since javax.annotation is already relocated, there's no need to add entries for that part.

resolved the comments.
changed to javax.annotations
Copy link
Author

@sindhushreem25 sindhushreem25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved the comments

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari changed the title Refactor client and server , moving the annotations from jcip to javax annotations [improve] replace jcip annotations to jsr305 annotations Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants