Skip to content

Comments

[fix][client] Reduce logging in OAuth auth to fix parsing of Pulsar cli command output#25254

Merged
lhotari merged 2 commits intoapache:masterfrom
lhotari:lh-reduce-oauth-auth-logging
Feb 23, 2026
Merged

[fix][client] Reduce logging in OAuth auth to fix parsing of Pulsar cli command output#25254
lhotari merged 2 commits intoapache:masterfrom
lhotari:lh-reduce-oauth-auth-logging

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Feb 19, 2026

Motivation

#24944 caused a regression by adding INFO logging. In many cases Pulsar CLI command output is parsed and the INFO logs will break output parsing.

Modifications

Change INFO to DEBUG level for the logging statements added in #24944

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.2.0 milestone Feb 19, 2026
@lhotari lhotari requested review from Technoboy- and nodece February 19, 2026 20:54
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 19, 2026
lhotari added a commit to apache/pulsar-helm-chart that referenced this pull request Feb 19, 2026
- set appVersion to 4.0.9
- fix broken CI with a workaround
  - Pulsar regression, which will be fixed by apache/pulsar#25254
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.65%. Comparing base (62e7ebc) to head (67d231d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...pache/pulsar/client/impl/auth/oauth2/FlowBase.java 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #25254      +/-   ##
============================================
+ Coverage     72.22%   72.65%   +0.43%     
- Complexity    34209    34414     +205     
============================================
  Files          1959     1959              
  Lines        155401   155403       +2     
  Branches      17724    17726       +2     
============================================
+ Hits         112243   112915     +672     
+ Misses        34182    33474     -708     
- Partials       8976     9014      +38     
Flag Coverage Δ
inttests 25.66% <0.00%> (-0.24%) ⬇️
systests 22.38% <0.00%> (+<0.01%) ⬆️
unittests 73.63% <0.00%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pache/pulsar/client/impl/auth/oauth2/FlowBase.java 62.06% <0.00%> (-5.79%) ⬇️

... and 140 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit 1f86c24 into apache:master Feb 23, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants