Skip to content

Conversation

@shisheng-1
Copy link

Compiler daemon. The Gradle Java plugin allows you to run the compiler as a separate process by setting options.fork = true. This feature can lead to much less garbage collection and make Gradle’s infrastructure faster. This project has more than 1000 source files. We can consider enabling this feature.

=====================
If there are any inappropriate modifications in this PR, please give me a reply and I will change them.

Copy link
Contributor

@cameronlee314 cameronlee314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. I just had a couple of minor questions.

build.gradle Outdated
Comment on lines 105 to 108
tasks.withType(JavaCompile).configureEach {
options.fork = true
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Could you please use 2 spaces for indentation instead of 4? Just for consistency with the rest of the file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, two spaces now

@james-deee
Copy link
Contributor

@cameronlee314 any reason not to merge this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants