Wait for pending commits to finish during shutdown. #1663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
This seems to time out builds, presumably due to test timeouts. Will debug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: BlobStoreStateBackendIntegrationTest.testStopAndRestart fails occassionally if SamzaContainer shuts down before pending commits for its tasks are complete. Note: This issue does not affect correctness of commits, but does affect test reliability.
Fix: 1) Wait for pending commits to complete before shutting the container down. 2) Shut down commitThreadPool after the pending commits are complete (otherwise queued tasks requried to complete commits will be cancelled and commits will be unsuccessful).
Test: BlobStoreStateBackendIntegrationTest.testStopAndRestart passes in a loop.