Skip to content

Close SystemConsumer properly #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryucc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Close SystemConsumer properly #1674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ class KafkaCheckpointManager(checkpointSpec: KafkaStreamSpec,
val expectedGrouperFactory: String = new JobConfig(config).getSystemStreamPartitionGrouperFactory

val systemConsumer = systemFactory.getConsumer(checkpointSystem, config, metricsRegistry, this.getClass.getSimpleName)
var systemConsumerStarted: Boolean = false
val systemAdmin = systemFactory.getAdmin(checkpointSystem, config, this.getClass.getSimpleName)

var taskNames: Set[TaskName] = Set[TaskName]()
Expand Down Expand Up @@ -121,6 +122,7 @@ class KafkaCheckpointManager(checkpointSpec: KafkaStreamSpec,
info(s"Starting the checkpoint SystemConsumer from oldest offset $oldestOffset")
systemConsumer.register(checkpointSsp, oldestOffset)
systemConsumer.start()
systemConsumerStarted = true
}

/**
Expand Down Expand Up @@ -148,6 +150,7 @@ class KafkaCheckpointManager(checkpointSpec: KafkaStreamSpec,
if (stopConsumerAfterFirstRead) {
info("Stopping system consumer")
systemConsumer.stop()
systemConsumerStarted = false
}
} else if (!stopConsumerAfterFirstRead) {
taskNamesToCheckpoints ++= readCheckpoints()
Expand Down Expand Up @@ -224,9 +227,10 @@ class KafkaCheckpointManager(checkpointSpec: KafkaStreamSpec,
info ("Stopping system producer.")
producerRef.get().stop()

if (!stopConsumerAfterFirstRead) {
if (systemConsumerStarted) {
info("Stopping system consumer")
systemConsumer.stop()
systemConsumerStarted = false
}

info("CheckpointManager stopped.")
Expand Down