Skip to content

upgraded file handling using NIO with Java8 onward #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hari-IBM wants to merge 2 commits into
base: main
Choose a base branch
from
Open

upgraded file handling using NIO with Java8 onward #242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7f836e
upgraded file handling using nio
hari-IBM Nov 20, 2024
8702677
resolved review comments
Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions ...unnel-app/src/main/java/org/apache/seatunnel/app/service/impl/JobExecutorServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,12 @@

import javax.annotation.Resource;

import java.io.BufferedWriter;
import java.io.File;
import java.io.FileWriter;
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.nio.file.StandardOpenOption;
import java.util.Date;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;
Expand All @@ -63,6 +65,10 @@
@Slf4j
@Service
public class JobExecutorServiceImpl implements IJobExecutorService {
private static final String DIR_PROFILE = "profile";
private static final String USER_DIR = "user.dir";
private static final String DOT_CONF = ".conf";

@Resource private IJobInstanceService jobInstanceService;
@Resource private IJobInstanceDao jobInstanceDao;

Expand Down Expand Up @@ -90,20 +96,15 @@ public Result<Long> jobExecute(Integer userId, Long jobDefineId, JobExecParam ex
}

public String writeJobConfigIntoConfFile(String jobConfig, Long jobDefineId) {
String projectRoot = System.getProperty("user.dir");
String filePath =
projectRoot + File.separator + "profile" + File.separator + jobDefineId + ".conf";
String projectRoot = System.getProperty(USER_DIR);
String dirPath = projectRoot + File.separator + DIR_PROFILE;
String filePath = dirPath + File.separator + jobDefineId + DOT_CONF;
try {
File file = new File(filePath);
if (!file.exists()) {
file.getParentFile().mkdirs();
}

FileWriter fileWriter = new FileWriter(file);
BufferedWriter bufferedWriter = new BufferedWriter(fileWriter);
Path path = Paths.get(dirPath);
Files.createDirectories(path);

bufferedWriter.write(jobConfig);
bufferedWriter.close();
Files.write(Paths.get(filePath), jobConfig.getBytes(), StandardOpenOption.CREATE);

log.info("File created and content written successfully.");
} catch (IOException e) {
Expand Down