Skip to content

Fix BrowserErrorLog BanyanDB storage query order. #13666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wankai123 merged 3 commits into from
Jan 14, 2026
+5 −1
Merged

Fix BrowserErrorLog BanyanDB storage query order. #13666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e611e90
Fix `BrowserErrorLog` BanyanDB storage query order.
wankai123 Jan 14, 2026
d07d7e8
Update oap-server/server-storage-plugin/storage-banyandb-plugin/src/m…
wankai123 Jan 14, 2026
d142068
fix
wankai123 Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/en/changes/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
* Fix BanyanDB time range overflow in profile thread snapshot query.
* `BrowserErrorLog`, OAP Server generated UUID to replace the original client side ID, because Browser scripts can't guarantee generated IDs are globally unique.
* MQE: fix multiple labeled metric query and ensure no results are returned if no label value combinations match.
* Fix `BrowserErrorLog` BanyanDB storage query order.

#### UI
* Fix the missing icon in new native trace view.
Expand Down
1 change: 1 addition & 0 deletions ...e/src/main/java/org/apache/skywalking/oap/server/core/storage/query/IMetricsQueryDAO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ public static List<String> composeLabelConditions(final List<KeyValue> queryLabe
keySets.add(keySet);
} else { // If any query label has no matches, clear all keySets so that no results are returned
keySets.clear();
break;
}
}
//intersection labels
Expand Down
4 changes: 3 additions & 1 deletion ...ache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBBrowserLogQueryDAO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package org.apache.skywalking.oap.server.storage.plugin.banyandb.stream;

import com.google.common.collect.ImmutableSet;
import org.apache.skywalking.library.banyandb.v1.client.AbstractQuery;
import org.apache.skywalking.library.banyandb.v1.client.RowEntity;
import org.apache.skywalking.library.banyandb.v1.client.StreamQuery;
import org.apache.skywalking.library.banyandb.v1.client.StreamQueryResponse;
Expand Down Expand Up @@ -70,7 +71,8 @@ public void apply(StreamQuery query) {
if (Objects.nonNull(category)) {
query.and(eq(BrowserErrorLogRecord.ERROR_CATEGORY, category.getValue()));
}

query.setOrderBy(
new StreamQuery.OrderBy(AbstractQuery.Sort.DESC));
query.setOffset(from);
query.setLimit(limit);
}
Expand Down
Loading