[SPARK-52964] Add merge_connect_rust_pr.py and PULL_REQUEST_TEMPLATE#3
Merged
xuanyuanking merged 2 commits intoapache:masterfrom Aug 7, 2025
Merged
Conversation
b3bd318 to
93691ff
Compare
Member
|
Thanks @sarutak for this change! |
Member
Author
|
@xuanyuanking Thank you for pointing it out. I'll update it. |
Member
Author
|
@xuanyuanking I checked the way Spark,
These all don't disable the merge button so how about leaving it as it is? |
Member
|
@sarutak ah make sense. Then let's just not use the button after merging the merge_script. Thanks for the further check! |
Member
Author
|
@xuanyuanking Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes adding
merge_connect_rust_pr.pyandPULL_REQUEST_TEMPLATElike the Spark repository does.These files are brought from Spark repository and tweaked. The diffs are:
diff spark-connect-rust/dev/merge_connect_rust_pr.py spark/dev/merge_spark_pr.pydiff spark-connect-rust/.github/PULL_REQUEST_TEMPLATE spark/.github/PULL_REQUEST_TEMPLATEI confirmed this script works by:
The commit log of the change merged by this script is like as follows.
Related Issue(s)
SPARK-52964