[SPARK-53011][TESTS] Fix test_df_unpivot to pass with Spark 4.0#4
Closed
sarutak wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-53011][TESTS] Fix test_df_unpivot to pass with Spark 4.0#4sarutak wants to merge 1 commit intoapache:masterfrom
sarutak wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
LGTM, will merge after we have the merge script! |
Member
Author
|
Now that we have a merge script am I OK to merge this by myself? |
Member
|
Yep, just go ahead for straightforward fixes! Thanks Sarutak! |
Member
Author
|
Merged to |
Member
Author
|
I noticed the PR title has a wrong JIRA ID. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes to fix the issue that
test_df_unpivotdoesn't pass with Spark 4.0.As of Spark 4.0, ANSI mode is enabled by default but this test doesn't consider it.
To fix this issue, I tweaked the test so that the test pass in both ANSI mode is enabled or not.
Related Issue(s)
SPARK-53001