Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Conversation

@ericholguin
Copy link
Contributor

This PR just simplifies the conditional used to check if roles and permissions are enabled.


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Run TO and make sure a user can view a secure parameter value with the right permissions

PR submission checklist

@ericholguin ericholguin added Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution labels Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 32.34%. Comparing base (75ec56f) to head (992a6fc).
⚠️ Report is 369 commits behind head on master.

Files with missing lines Patch % Lines
...fic_ops/traffic_ops_golang/parameter/parameters.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #7739       +/-   ##
=============================================
- Coverage     65.05%   32.34%   -32.72%     
  Complexity       98       98               
=============================================
  Files           314      710      +396     
  Lines         12365    79773    +67408     
  Branches        907      965       +58     
=============================================
+ Hits           8044    25799    +17755     
- Misses         3968    51828    +47860     
- Partials        353     2146     +1793     
Flag Coverage Δ
golib_unit 52.63% <ø> (?)
grove_unit 12.02% <ø> (?)
t3c_unit 5.99% <ø> (?)
traffic_monitor_unit 26.33% <ø> (?)
traffic_ops_integration ∅ <ø> (∅)
traffic_ops_unit 22.44% <0.00%> (?)
traffic_portal_v2 70.84% <ø> (∅)
traffic_stats_unit 10.76% <ø> (?)
unit_tests 27.60% <0.00%> (∅)
v3 ∅ <ø> (∅)
v4 ∅ <ø> (∅)
v5 ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant