Add debug instrumentation to Stripe destructor #12754
Open
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add debug logging, validation assertions, and memory poisoning to help track down intermittent heap corruption issues during cache cleanup. - Add Dbg() logging with pointer address, size, and allocation type - Add assertions to validate size is reasonable before freeing - Add memory poisoning (0xDE pattern) in DEBUG builds before free - Reset raw_dir_size to 0 after freeing This helps diagnose issues like "free(): corrupted unsorted chunks" that can occur intermittently during cache test cleanup.
Contributor
Author
|
[approve ci centos] |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds debug instrumentation to the Stripe destructor to help diagnose intermittent heap corruption issues that occur during cache cleanup, particularly the free(): corrupted unsorted chunks errors seen in CI testing.
- Adds debug logging with pointer address, size, and allocation type details
- Adds validation assertions to detect corrupted size values before freeing
- Adds memory poisoning in DEBUG builds to catch use-after-free bugs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
[approve ci centos] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
free(): corrupted unsorted chunksthat can occur intermittently during cache test cleanup (seen in CI build #47769)Changes
Dbg()logging with pointer address, size, and allocation type (enable withT:cache_freedebug tag)0xDEpattern) in DEBUG builds before free to detect use-after-freeraw_dir_sizeto 0 after freeingTest plan