Cleanup connect result handling #12766
Open
+56
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR is derived from #12729.
Since the changes in that PR mixed a bug fix and cleanup work, we decided to split them into two separate PRs.
This PR extracts and focuses on the cleanup portion.
The motivation for this cleanup is that pre-setting
EIOinconnect_resultbefore a connection attempt is error-prone.Instead, we want to set an error in
connect_resultonly when a connection error actually occurs.This work was triggered by the following review comment:
#12729 (comment)
Note
For the background on why
EIOstarted being pre-set inconnect_resultbefore connection attempts, see #7580Cleanup details
See the following comment for details:
#12729 (comment)