Skip to content

Use malloc allocated buffers for h2 headers if enabled #12767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmcfarlen wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −3
Open

Use malloc allocated buffers for h2 headers if enabled #12767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions include/proxy/http2/Http2CommonSession.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,11 @@ enum class Http2SsnMilestone {
LAST_ENTRY,
};

#if TS_USE_MALLOC_ALLOCATOR
size_t const HTTP2_HEADER_BUFFER_SIZE_INDEX = BUFFER_SIZE_INDEX_FOR_XMALLOC_SIZE(4096);
#else
size_t const HTTP2_HEADER_BUFFER_SIZE_INDEX = BUFFER_SIZE_INDEX_4K;
#endif

/**
@startuml
Expand Down
10 changes: 7 additions & 3 deletions include/proxy/http2/Http2Stream.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,14 @@ class Http2Stream : public ProxyTransaction
Http2StreamState _state = Http2StreamState::HTTP2_STREAM_STATE_IDLE;
int64_t _http_sm_id = -1;

HTTPHdr _receive_header;
HTTPHdr _receive_header;
#if TS_USE_MALLOC_ALLOCATOR
MIOBuffer _receive_buffer{BUFFER_SIZE_INDEX_FOR_XMALLOC_SIZE(4096)};
#else
MIOBuffer _receive_buffer{BUFFER_SIZE_INDEX_4K};
VIO read_vio;
VIO write_vio;
#endif
VIO read_vio;
VIO write_vio;

History<HISTORY_DEFAULT_SIZE> _history;
Milestones<Http2StreamMilestone, static_cast<size_t>(Http2StreamMilestone::LAST_ENTRY)> _milestones;
Expand Down