Fix: HTTPHdr host cache invalidation when Host header modified #12768
+387
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a plugin or internal code modifies the Host header via MIME layer functions (e.g.,
mime_field_value_set), the HTTPHdr cached host info becomes stale. The cachedm_host_lengthdoesn't match the new value, causinghost_get()to return incorrect data with garbage characters appended.Symptom: SNI warnings in diags.log showing garbage characters appended to hostnames:
Root Cause
HTTPHdr caches host info in
_fill_target_cache()but MIME layer modifications bypass HTTPHdr, leavingm_target_cachedtrue with stalem_host_length.Fix
Detect staleness by caching both the host value pointer and raw length. On access, compare current MIMEField values against cached values. If either differs, the value was modified and we refill the cache.
This approach:
Testing
Added comprehensive unit tests covering host header modifications with various scenarios including port handling (47 assertions).