Create blog section ui/ux #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #21173: Create Blog section ui/ux. |
Jared-Dev
reviewed
May 17, 2021
Contributor
Jared-Dev
left a comment
Jared-Dev
left a comment
There was a problem hiding this comment.
We have some data we need to throw in here and we need the actual blog view to be built out.
Comment on lines
44
to
46
| {/*<ShapeBottmRight>*/} | ||
| {/* <img src={imgL1FeatureCurve} alt="" className="img-fluid" />*/} | ||
| {/*</ShapeBottmRight>*/} |
Collaborator
Author
There was a problem hiding this comment.
Preview the blog specific page will be on the landing page?
Contributor
There was a problem hiding this comment.
No, we'll need to add a page. So in the repo we should add src/pages/blog/[postId].js
Collaborator
Author
There was a problem hiding this comment.
Good. Where I can find data for blogs?
Contributor
There was a problem hiding this comment.
We talked about it in Standup, but for now lets just use the static data from the design file. We are still waiting on the backend to have live data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.