Skip to content

Re-implement unquantization in pure Python #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
astrofrog wants to merge 32 commits into
base: fits-byte-compress-decompress
Choose a base branch
from
Draft

Re-implement unquantization in pure Python #48

astrofrog wants to merge 32 commits into from

Conversation

@astrofrog
Copy link

@astrofrog astrofrog commented Dec 16, 2022 •
edited
Loading

Main TODOs:

  • Get test to pass, determine if just a tolerance issue or how to get better agreement
  • Avoid looping over the data
  • Add back full imcompress.c files

Cadair and others added 30 commits December 15, 2022 11:06
@Cadair
Implement FITS Compression algorithms in Codec classes
8ed0750
@Cadair
Add canonical compressed data from FITS site
314f986
@Cadair
Fix up some tests and let gzip fail
992c03b
@Cadair
Test against calls to fitsio
17dce4e
@astrofrog @Cadair
Remove compressionmodule.c in favor of astropy.io.fits.tiled_compression
7d84890
@astrofrog @Cadair
Use new Python compress_hdu and decompress_hdu functions
f26913d
@astrofrog @Cadair
Various improvements to (de)compress_hdu
b51be83
@astrofrog @Cadair
Fix fitsio tests for all compression types
c3575fc
@astrofrog @Cadair
More fixes to compress_hdu
1a283af
@Cadair
Improve the fitsio tests
03ee063
@Cadair
Support lossless GZIP decompression (with fitsio tests)
625aba6
@astrofrog @Cadair
Use cfitsio for quantization
55a6839
@astrofrog @Cadair
Starting adding support for de-quantization in decompress_hdu
249cbe4
@astrofrog @Cadair
Finish implementing reading in of lossless GZIP fallback
4e109a2
@astrofrog @Cadair
Enable lossy floating point tests for GZIP
773b3f7
@astrofrog @Cadair
Remove unneeded tests and simplify canonical tests
94a30b1
@astrofrog @Cadair
Renamed lossless to gzip_fallback and don't have Quantize inherit fro…
b0263b1 
…m Codec
@Cadair
Split up tiled_compression.py
444c20e
@astrofrog @Cadair
Fixed test_empty
9e8b993
@astrofrog @Cadair
Fix tests related to PLIO compression (in which gzip fallback is used)
6018700
@astrofrog @Cadair
Include an exact zero in test data and make sure this is preserved ex…
e7a5a77 
…actly with SUBTRACTIVE_DITHER_2
@astrofrog @Cadair
Added support for ZBLANK
e302f8d
@Cadair
Attempt to fix the PLIO compression segfault
f58e55d
@Cadair
TMP: Remove some unused code from imcompress.c
bfd4e2f 
This commit should be able to be dropped / modified when we actually
remove the unused bits of cfitsio.
@Cadair
Apply suggestions from code review
2551958
@Cadair
Some docstring improvements
0949b41
@Cadair
Guard against a segfault in HCOMPRESS
857337f 
This validates the case where the shape for a tile is passed incorrectly
to the C wrapper
@Cadair
i heard you like PLIO segfaults, so I made PLIO segfault again
3b52ce4
@Cadair
TMP: Remove gate on initial_checks
7e1d659
@Cadair
Actually test the tile shape we wanted to test
e28e369
@github-actions
Copy link

github-actions bot commented Dec 16, 2022

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@astrofrog astrofrog mentioned this pull request Dec 17, 2022
Open
@Cadair Cadair force-pushed the fits-byte-compress-decompress branch 2 times, most recently from 863e4f8 to 8ac61d9 Compare December 23, 2022 13:05
@Cadair Cadair force-pushed the fits-byte-compress-decompress branch 3 times, most recently from a93c06e to 9d19273 Compare January 4, 2023 18:38
@astrofrog astrofrog force-pushed the fits-byte-compress-decompress branch 5 times, most recently from 7278254 to 1ed7e1e Compare January 19, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

io.fits

Projects

None yet

Milestone

After first PR to astropy core

Development

Successfully merging this pull request may close these issues.

2 participants

@astrofrog @Cadair